Closed as duplicate of#71952
Description
gopls version
➜ gopls -v version
Build info
----------
golang.org/x/tools/gopls v0.18.1
golang.org/x/tools/[email protected] h1:2xJBNzdImS5u/kV/ZzqDLSvlBSeZX+pWY9uKVP7Pask=
github.com/BurntSushi/[email protected] h1:pxW6RcqyfI9/kWtOwnv/G+AzdKuy2ZrqINhenH4HyNs=
github.com/google/[email protected] h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
golang.org/x/exp/[email protected] h1:1xaZTydL5Gsg78QharTwKfA9FY9CZ1VQj6D/AZEvHR0=
golang.org/x/[email protected] h1:Zb7khfcRGKk+kqfxFaP5tZqCnDZMjC5VtUBs87Hr6QM=
golang.org/x/[email protected] h1:GGz8+XQP4FvTTrjZPzNKTMFtSXH80RAzG+5ghFPgK9w=
golang.org/x/[email protected] h1:L2k9GUV2TpQKVRGMjN94qfUMgUwOFimSQ6gipyJIjKw=
golang.org/x/[email protected] h1:bofq7m3/HAFvbF51jz3Q9wLg3jkvSPuiZu/pD1XwgtM=
golang.org/x/[email protected] h1:Ja/5gV5a9Vvho3p2NC/T2TtxhHjrWS/2DvCKMvA0a+Y=
golang.org/x/[email protected] h1:NPGnvPOTgnjBc9HTaUx+nj+EaUYxl5SJOWqaDYGaFYw=
honnef.co/go/[email protected] h1:4bH5o3b5ZULQ4UrBmP+63W9r7qIkqJClEA9ko5YKx+I=
mvdan.cc/[email protected] h1:bg91ttqXmi9y2xawvkuMXyvAA/1ZGJqYAEGjXuP0JXU=
mvdan.cc/xurls/[email protected] h1:lyBNOm8Wo71UknhUs4QTFUNNMyxy2JEIaKKo0RWOh+8=
go: go1.24.1
go env
N/AWhat did you do?
Ran go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -test -fix ./... on code similar to the following:
func main() {
var i int
for i = 0; i < 10; i++ {}
println(i)
}
What did you see happen?
modernize transformed the code to:
func main() {
var i int
for i = range 10 {}
println(i)
}
This is a functional change, since the range over int doesn't perform the final increment. This code prints 9.
What did you expect to see?
The original implementation would print 10, since the final increment occurs even if the loop body doesn't execute. I would expect to see the same behavior after applying modernize fixes.
The modernize tool should probably not apply this change if the loop variable's scope is greater than that of the loop itself (unless it can determine that the loop variable is no longer used after the loop completes).
Editor and settings
No response
Logs
No response