proposal: x/sync/errgroup: add Propagate field

[qiulaidongfeng]

Proposal Details

See #74304 (comment) and #53757 (comment) , Sometimes we need to restore the old behavior of errgroup, and I suggest adding a new field Propagate to achieve this, turning the new behavior into an option to join.

Don't use GODEBUG because don't know what to set its default value and what to enable new behavior when the go line in go.mod changes to.

I can send CL implement this proposal.

open-ended question：
Do we also need to adopt https://go.dev/cl/682335 or #74275 for faster panic when using new behaviors?

[gabyhelp]

Related Issues

• proposal: x/sync/errgroup: propagate panics through Go #74275
• proposal: x/sync/errgroup: optionally collect all errors #72101 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[seankhliao]

It sounds like in #53757 that we should just revert it and allow crashes to happen.
Should we close this?

[adonovan]

It sounds like in #53757 that we should just revert it and allow crashes to happen. Should we close this?

I think so, yes. Users of errgroup can already implement the semantics they want on top of errgroup.

[gopherbot]

Change https://go.dev/cl/682935 mentions this issue: errgroup: revert propagation of panics