Skip to content

fix(dep): Pin golang.org/x/tools dependency #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Dec 29, 2020

Description

Currently, golangci-lint is failed for all repos using vendoring.

As suggested by @lukasmalkmus, pinning golang.org/x/tools to
9cf592e881e9 to fix the issue.

Relates #1502

Signed-off-by: Tam Mach [email protected]

Note: I tried to avoid replace directive, but can't without downgrading mvdan.cc/gofumpt package.

Testing

Before

$ make lint
golangci-lint run
ERRO Running error: context loading failed: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: build flag -mod=readonly only valid when using modules
make: *** [lint] Error 3

After

$ make lint
golangci-lint run

@sayboras sayboras requested a review from a team December 29, 2020 09:30
Currently, golangci-lint is failed for all repos using vendoring.

As suggested by @lukasmalkmus, pinning golang.org/x/tools to
9cf592e881e9 to fix the issue.

Relates golangci#1502

Signed-off-by: Tam Mach <[email protected]>
@ldez ldez self-requested a review December 29, 2020 11:40
@ldez
Copy link
Member

ldez commented Dec 29, 2020

#1502 (comment)

@ldez
Copy link
Member

ldez commented Dec 29, 2020

I created another fix: #1593

@sayboras WDYT?

@sayboras
Copy link
Member Author

@ldez thanks, it's much better than pinning version 💯 . Let me close this one in favor of #1593

@sayboras sayboras closed this Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants