Use upstream gocyclo library #1741
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess in the past it was not possible to use it directly, hence fork was used. This commit also simplifies the logic a bit of the linter. Signed-off-by: Mateusz Gozdek <[email protected]>
|
It's a duplicate of #1739 |
|
Oh, thanks for pointing out @ldez. Do you mind also pulling my part of code which simplifies some bits please? I think they are valuable. |
ldez
added a commit
to ldez/golangci-lint
that referenced
this pull request
Feb 17, 2021
ldez
added a commit
to ldez/golangci-lint
that referenced
this pull request
Feb 17, 2021
ldez
added a commit
to ldez/golangci-lint
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess in the past it was not possible to use it directly, hence fork
was used.
This commit also simplifies the logic a bit of the linter.
Signed-off-by: Mateusz Gozdek [email protected]