Skip to content

go1.19 support #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 3, 2022
Merged

go1.19 support #3037

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3af3181
chore: quick cleaning
ldez Jul 15, 2022
513e8d4
chore: update Go versions
ldez Jul 15, 2022
11fef98
compatibility with previous version of golangci-lint
ldez Aug 1, 2022
fb963b1
netlify: downgrade Go version
ldez Aug 1, 2022
8b175ac
go1.19 fmt
ldez Aug 1, 2022
b635b3c
chore: bump to stable version
ldez Aug 3, 2022
d20f503
doc: improve comments
ldez Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: bump to stable version
  • Loading branch information
@ldez
ldez committed Aug 3, 2022
commit b635b3c4a3acfa37bf2a7364cdb09026a806f540
4 changes: 2 additions & 2 deletions .github/workflows/post-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: 1.19.0-rc.2
# stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: 1.19

- name: Update GitHub action config
run: make assets/github-action-config.json
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-extra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: 1.19.0-rc.2
# stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: 1.19
- name: Run go list
run: go list -json -m all > go.list
- name: Nancy
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
pull_request:

env:
GO_VERSION: 1.19.0-rc.2
GO_VERSION: 1.19

jobs:
# Check if there any dirty change for go mod tidy
Expand All @@ -16,7 +16,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: ${{ env.GO_VERSION }}
- name: Checkout code
uses: actions/checkout@v3
Expand All @@ -34,8 +34,8 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# go-version: ${{ env.GO_VERSION }}
# stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# go-version: ${{ env.GO_VERSION }} # todo(ldez) uncomment after the next release v1.48.0
go-version: 1.18
- name: lint
uses: golangci/[email protected]
Expand All @@ -53,7 +53,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: ${{ env.GO_VERSION }} # test only the latest go version to speed up CI
- name: Run tests
run: make.exe test
Expand All @@ -67,7 +67,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: ${{ env.GO_VERSION }} # test only the latest go version to speed up CI
- name: Run tests
run: make test
Expand All @@ -79,13 +79,13 @@ jobs:
matrix:
golang:
- 1.18
- 1.19.0-rc.2
- 1.19
steps:
- uses: actions/checkout@v3
- name: Install Go
uses: actions/setup-go@v3
with:
stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: ${{ matrix.golang }}
- uses: actions/cache@v3
with:
Expand All @@ -109,7 +109,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: ${{ env.GO_VERSION }}
- name: Check generated files are up to date
run: make fast_check_generated
8 changes: 4 additions & 4 deletions .github/workflows/tag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: 1.19.0-rc.2
# stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: 1.19
- name: Unshallow
run: git fetch --prune --unshallow

Expand All @@ -41,8 +41,8 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: 1.19.0-rc.2
# stable: 'false' # Keep this line to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
go-version: 1.19

- name: Unshallow
run: git fetch --prune --unshallow
Expand Down