-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat!: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization #3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Replace ListCursorOptions with ListIDPGroupsOptions in TeamsService.ListIDPGroupsInOrganization #3197
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3197 +/- ##
==========================================
- Coverage 97.72% 92.91% -4.81%
==========================================
Files 153 171 +18
Lines 13390 11558 -1832
==========================================
- Hits 13085 10739 -2346
- Misses 215 726 +511
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @laughedelic .
One minor change, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @laughedelic !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Hi! Is there anything I can do to move this forward? |
If you have any coworkers or know of any other contributors to this repo (who are all volunteers, please remember), feel free to reach out to request a code review if you are comfortable with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @arymoraes ! |
Fixes #3196.
BREAKING CHANGE: Replace
ListCursorOptions
withListIDPGroupsOptions
inTeamsService.ListIDPGroupsInOrganization
I followed the template of this PR, fixing a similar issue: #3094.
Let me know if there is a better way to handle this. And I'm open to better naming suggestions.