feat!: Fix source property on Repo Custom Properties
#3333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlewis
added
NeedsReview
gmlewis
changed the title
source property on Repo Custom Properties
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3333 +/- ##
==========================================
- Coverage 97.72% 93.01% -4.71%
==========================================
Files 153 172 +19
Lines 13390 14848 +1458
==========================================
+ Hits 13085 13811 +726
- Misses 215 944 +729
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
gmlewis
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Thank you, @claystation, and I apologize for the breakage, as I should have caught that.
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
tomfeigin
approved these changes
Oct 27, 2024
|
Thank you, @tomfeigin ! (The test breakage appears to be unrelated to this PR - I will investigate and fix in a separate PR.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Change
RulesetRepositoryPropertyTargetParameters.Sourcefromstringto*string.Our application was failing to apply or update Github Rulesets because of the following error:
Following the release of Go Github v65. Digging into this we saw a change in the following PR #3250.
Looking into the Github REST API the
sourceattribute is not listed as required. Thus we also did not implement this on our side. The problem that surfaced was the fact that the property was still being sent to the Github API even though it was empty.With this PR we make it optional, a pointer, and i adapted test cases to verify that it is indeed missing when empty.
I tested this with our own fork of Go Github and it works for our case again.
Let me know what you think!