Skip to content

Add missing Deployment field to workflow_job event type #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add missing Deployment field to workflow_job event type #3353

merged 1 commit into from
Nov 20, 2024

Conversation

AirOne70
Copy link
Contributor

The workflow_job webhook event as described by GitHub documentation contains a deployment object.
https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_job

However, the struct that defines the workflow_job webhook event type is missing the deployment object . This PR adds the missing object to the WorkflowJobEvent type.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (2b8c7fa) to head (dc752c2).
Report is 174 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3353      +/-   ##
==========================================
- Coverage   97.72%   92.30%   -5.42%     
==========================================
  Files         153      176      +23     
  Lines       13390    15031    +1641     
==========================================
+ Hits        13085    13874     +789     
- Misses        215     1064     +849     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AirOne70 !
LGTM.
Merging.

@gmlewis gmlewis merged commit 6d30edd into google:master Nov 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants