-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Remove the beta endpoint for Copilot usage #3354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3354 +/- ##
==========================================
- Coverage 97.72% 92.30% -5.42%
==========================================
Files 153 176 +23
Lines 13390 15031 +1641
==========================================
+ Hits 13085 13874 +789
- Misses 215 1064 +849
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@henriklundstrom - I'm confused - wasn't GitHub's OpenAPI spec updated to include your new endpoints? |
@gmlewis There are two sets of endpoints for Copilot metrics. They do largely the same things and both of them were launched very recently. First there was a beta launch, and then shortly thereafter a GA version to replace it. Beta: GA: |
@henriklundstrom - thank you for the excellent explanation. That makes perfect sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @henriklundstrom !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
// GetOrganizationUsage gets daily breakdown of aggregated usage metrics for Copilot completions and Copilot Chat in the IDE across an organization. | ||
// | ||
// GitHub API docs: https://docs.github.com/rest/copilot/copilot-usage#get-a-summary-of-copilot-usage-for-organization-members | ||
// | ||
//meta:operation GET /orgs/{org}/copilot/usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's better to mark these functions as Deprecated: use ... instead
and not removing them? We can always remove them later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with deleting since the removed code has not been officially released in this repo with any tagged release.
That's why I removed the Breaking Change label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the description, hopefully it's more clear now.
Thank you, @alexandear ! |
Note: This is a breaking change only in the sense that it removes the endpoints added by 5e806b6, but that commit has not yet made it to any release, so in that sense it is not breaking with any previous release.
Removes support for the beta endpoint for Copilot usage metrics, which is scheduled for removal by GitHub by the end of the year, see https://github.blog/changelog/2024-10-30-github-copilot-metrics-api-ga-release-now-available/. Support for the GA endpoint was implemented by 717e93f.