Skip to content

Add deprecation messages to security managers APIs #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add deprecation messages to security managers APIs #3426

merged 1 commit into from
Jan 7, 2025

Conversation

just-joshing
Copy link
Contributor

The organization security manager role REST APIs are being sunset (https://gh.io/security-managers-rest-api-sunset) in favor of the organization roles REST APIs.

This change adds deprecation messages to tell consumers which client operations to use instead going forward.

@just-joshing
Copy link
Contributor Author

I had previously tried updating these operations instead to use the replacement client methods under-the-hood but got feedback to go the deprecation route instead.

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @just-joshing and @stevehipwell !
LGTM.
Merging.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (2b8c7fa) to head (9f0b14d).
Report is 217 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3426      +/-   ##
==========================================
- Coverage   97.72%   92.22%   -5.51%     
==========================================
  Files         153      173      +20     
  Lines       13390    14937    +1547     
==========================================
+ Hits        13085    13775     +690     
- Misses        215     1068     +853     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants