-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(ci): ensure 'auto' toolchain applies to generate #3436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dnwe - I would also personally appreciate it if you stopped using force-push in this repo, because this is not the same as what I originally reviewed, and it helps me to see the progression. Thank you! |
Apart from the first time (where I corrected a mistake pre-review) that was just me hitting rebase in the UI because my branch was out-of-date with master. The UI does show each of the commit refs for each rebase |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3436 +/- ##
==========================================
- Coverage 97.72% 91.21% -6.51%
==========================================
Files 153 182 +29
Lines 13390 15930 +2540
==========================================
+ Hits 13085 14531 +1446
- Misses 215 1225 +1010
- Partials 90 174 +84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Applying suggestion
Applying suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually applied suggestions.
LGTM.
Merging.
No description provided.