Skip to content

fix(ci): ensure 'auto' toolchain applies to generate #3436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

dnwe
Copy link
Contributor

@dnwe dnwe commented Jan 16, 2025

No description provided.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 16, 2025

@dnwe - I would also personally appreciate it if you stopped using force-push in this repo, because this is not the same as what I originally reviewed, and it helps me to see the progression. Thank you!

@dnwe
Copy link
Contributor Author

dnwe commented Jan 16, 2025

@dnwe - I would also personally appreciate it if you stopped using force-push in this repo, because this is not the same as what I originally reviewed, and it helps me to see the progression. Thank you!

Apart from the first time (where I corrected a mistake pre-review) that was just me hitting rebase in the UI because my branch was out-of-date with master. The UI does show each of the commit refs for each rebase

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.21%. Comparing base (2b8c7fa) to head (2b83750).
Report is 274 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3436      +/-   ##
==========================================
- Coverage   97.72%   91.21%   -6.51%     
==========================================
  Files         153      182      +29     
  Lines       13390    15930    +2540     
==========================================
+ Hits        13085    14531    +1446     
- Misses        215     1225    +1010     
- Partials       90      174      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

s4mur4i added a commit to s4mur4i/go-github that referenced this pull request Jan 16, 2025
s4mur4i added a commit to s4mur4i/go-github that referenced this pull request Jan 17, 2025
Applying suggestion
Applying suggestion
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually applied suggestions.
LGTM.
Merging.

@gmlewis gmlewis merged commit 76d1d46 into google:master Mar 10, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants