-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: Add missing query params to AlertListOptions #3477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I ran the linting, testing and generation scripts. @gmlewis can you please take a look? 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3477 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 179 179
Lines 15551 15551
=======================================
Hits 14158 14158
Misses 1221 1221
Partials 172 172 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @maaarcelino!
LGTM.
Merging.
@gmlewis Thanks! Any word on when I can expect a new release? Is there any chance you could do a minor release sooner than later? |
Usually we cut a release monthly, but we've also tried to be accommodating to requests, so I can work on a minor release. |
Done: https://github.com/google/go-github/releases/tag/v69.1.0 |
That's fantastic. Thank you so much @gmlewis! ❤️ |
As per the official documentation the endpoints to list alerts for both an organization and a repository accept three additional params which are not included in this SDK. Those are:
tool_guid
,direction
andsort
.See:
This PR adds those fields and extends the tests to cover them as well.