Skip to content

feat!: Add ListReactionOptions to all ListxxReactions functions to enable filter by content #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

colbylwilliams
Copy link
Contributor

@colbylwilliams colbylwilliams commented Mar 25, 2025

BREAKING CHANGE: ListCommentReactionOptions => ListReactionOptions and all List*Reactions methods now use it.

All list reactions endpoint now suppor the content query parameters to filter the returned results by content (+1, eyes, etc.). Including:

This PR updates all ListxxReactions functions corresponding to the APIs above, replacing the generic ListOptions with ListReactionOptions which contains the Content field.

Note on breaking changes: ListCommentReactions already utilzed a options param struct: ListCommentReactionOptions. This PR replaces that with ListReactionOptions to maintain consistency. This change and all the ListOptions should be considered breaking.

Copy link

google-cla bot commented Mar 25, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (3cac18b) to head (9c28048).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3532   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files         184      184           
  Lines       16143    16143           
=======================================
  Hits        14739    14739           
  Misses       1230     1230           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title Add ListReactionOptions to all ListxxReactions functions to enable filter by content feat!: Add ListReactionOptions to all ListxxReactions functions to enable filter by content Mar 25, 2025
@gmlewis gmlewis added Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). NeedsReview PR is awaiting a review before merging. labels Mar 25, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @colbylwilliams!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - might you have time for a code review? Thank you!

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 26, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 26, 2025

Thank you, @stevehipwell!
Merging.

@gmlewis gmlewis merged commit 51d32d9 into google:master Mar 26, 2025
7 checks passed
@colbylwilliams colbylwilliams deleted the reaction-list branch March 26, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants