-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat!: Add ListReactionOptions to all ListxxReactions functions to enable filter by content #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3532 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 184 184
Lines 16143 16143
=======================================
Hits 14739 14739
Misses 1230 1230
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @colbylwilliams!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @stevehipwell! |
BREAKING CHANGE:
ListCommentReactionOptions
=>ListReactionOptions
and allList*Reactions
methods now use it.All list reactions endpoint now suppor the
content
query parameters to filter the returned results by content (+1
,eyes
, etc.). Including:This PR updates all
ListxxReactions
functions corresponding to the APIs above, replacing the genericListOptions
withListReactionOptions
which contains theContent
field.Note on breaking changes:
ListCommentReactions
already utilzed a options param struct:ListCommentReactionOptions
. This PR replaces that withListReactionOptions
to maintain consistency. This change and all theListOptions
should be considered breaking.