Skip to content

chore: Remove redundant in Go 1.22 loop variables #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

alexandear
Copy link
Contributor

The PR removes tc := tc in tests and enables copyloopvar to detect such statements in the future. See https://go.dev/blog/loopvar-preview

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (0710d0b) to head (c043e65).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3537   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files         184      184           
  Lines       16169    16169           
=======================================
  Hits        14765    14765           
  Misses       1230     1230           
  Partials      174      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Merging.

@gmlewis gmlewis merged commit 3a3f51b into google:master Apr 2, 2025
7 checks passed
@alexandear alexandear deleted the chore/copyloopvar branch April 2, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants