Skip to content

fix: Add back repository field in Package struct #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

jBouyoud
Copy link
Contributor

@jBouyoud jBouyoud commented Apr 7, 2025

Hi,

As mentioned in the previous reply, the Repository field was mistakenly removed in Package strcuture.

This PR aims to reintroduce it.

cc @gmlewis

Copy link

google-cla bot commented Apr 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jBouyoud jBouyoud force-pushed the fix-add-missing-repository-field branch from f4d63ec to b2797a6 Compare April 7, 2025 12:48
@jBouyoud jBouyoud marked this pull request as ready for review April 7, 2025 12:48
@gmlewis gmlewis changed the title fix: add back repository field in package struct fix: Add back repository field in package struct Apr 7, 2025
@gmlewis gmlewis changed the title fix: Add back repository field in package struct fix: Add back repository field in Package struct Apr 7, 2025
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (3a3f51b) to head (b2797a6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3539   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         184      184           
  Lines       16169    16169           
=======================================
  Hits        14762    14762           
  Misses       1231     1231           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jBouyoud!
LGTM.
Merging.

@gmlewis gmlewis merged commit b6dbc4e into google:master Apr 7, 2025
7 checks passed
@jBouyoud jBouyoud deleted the fix-add-missing-repository-field branch April 7, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants