gmock_gen.py discards argument specifiers when they are defaulted

[hermas55]

Example :

class Foo {
public:
  virtual void Bar( const int a = 42 ) ;
};

Expected output :

class MockFoo : public Foo {
public:
    MOCK_METHOD1(Bar, void(const int a));
};

Actual output (const and parameter name discarded) :

class MockFoo : public Foo {
public:
    MOCK_METHOD1(Bar, void(int));
};

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[hermas55]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[gennadiycivil]

@hermas55 The scripts in the /script directory are out of date and not well supported anymore . I would be glad to merge this PR if you explain your usage.
Thank you
G

[gennadiycivil]

@hermas55 ping?

[hermas55]

Hello @gennadiycivil ,

Sure. There is as bug in the gmock_gen.py script.
It's supposed to take in input a header file of the class you want to mock, and print the mocked class in output.

It works fine as long as the class in input doesn't have methods with default parameters. When there are default parameters, the const qualifier gets discarded.

Example of Input class :

class Foo {
public:
  virtual void Bar( const int a = 42 ) ;
};

Output before the fix (const and parameter name discarded) :

class MockFoo : public Foo {
public:
    MOCK_METHOD1(Bar, void(int));
};

Output after the fix :

class MockFoo : public Foo {
public:
    MOCK_METHOD1(Bar, void(const int a));
};

The PR contains 3 commits :

• PEP8 Automatic reformatting --> Only reformatting to comply with PEP8 standard
• Fix for compatibility with Python 3.7 --> Make the script work with both Python 2.x and Python 3.x
• Fix default parameters with specifiers issue --> Fix for the issue explained above + Unittests

Please let me know if you have any concerns.

Kind regards,
//HM

[gennadiycivil]

@hermas55 Headsup, we are going to include the files under /scrips with the sync process that syncs the files internally and on GitHub. ( We will also include a disclaimer that these files are unsupported. )
All this means that there may be changes in the files you are working with. You may have to re-base this PR . we shall see

[gennadiycivil]

@hermas55 please resolve conflicts

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[hermas55]

conflicts resolved

[gennadiycivil]

Thank you, we have started internal review. Please don't push any more changes into this PR as they might be overwritten.
(276062823)