Fix "unused variable" warning when GTEST_HAS_STREAM_REDIRECTION is set to false in gtest-port.cc #3863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "unused variable" warning when GTEST_HAS_STREAM_REDIRECTION is set to false in gtest-port.cc
gaspardpetit
changed the title
derekmauro
reviewed
Jun 7, 2022
googletest/src/gtest-port.cc
Outdated
| namespace testing { | ||
| namespace internal { | ||
|
|
||
| #if GTEST_HAS_STREAM_REDIRECTION |
Member
There was a problem hiding this comment.
Instead of placing the guards here, can these variables simply be moved closer to where they are used, near CaptureStdout()/CaptureStderr(), where they would already be inside the GTEST_HAS_STREAM_REDIRECTION block?
Move declaration of kStdOutFileNo and kStdErrFileno closer to where they are used to avoid having to guard for GTEST_HAS_STREAM_REDIRECTION twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "unused variable" warning when GTEST_HAS_STREAM_REDIRECTION is set to false in gtest-port.cc
The three guarded constants are used only when
GTEST_HAS_STREAM_REDIRECTIONis enabled and currently trigger the following warnings whenGTEST_HAS_STREAM_REDIRECTIONis disabled: