Skip to content

Add dark/light theme support #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MDJAVEED7
Copy link

This PR introduces a theme toggle feature that allows users to switch between light and dark modes across the website.

🔧 Key Changes:
Added two CSS files:

theme-dark.css

theme-light.css

Integrated a theme toggle button in the top navigation bar

Saved the selected theme using localStorage so it persists across sessions

Updated default.html to dynamically load the selected theme on page load

🧪 Tested on:
Desktop (Chrome, Firefox)

Mobile responsive check

Theme toggle works across all pages and persists reloads

📌 Notes:
Let me know if you'd like the theme colors tweaked or the toggle placed differently.

Copy link

google-cla bot commented Apr 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rspier
Copy link
Collaborator

rspier commented Apr 10, 2025

Thanks Mohammed. Can you re-push without the indentation changes?

@MDJAVEED7
Copy link
Author

i cant able to understand by means of indentation

@rspier
Copy link
Collaborator

rspier commented Apr 23, 2025

Please rebase these changes against head, which should fix markdownlint, and merge the changes to fix the indentation from #131 in.

There shouldn't be whitespace only changes like this:
image

@MDJAVEED7
Copy link
Author

Please check one I have edited it

@rspier
Copy link
Collaborator

rspier commented Apr 28, 2025

There are still a ton of whitespace changes.

image

Your editor appears to be changing it from 4 space indent to 2 space indent, and re-wrapping the entire file.

Please only make the targeted changes needed to implement dark/light theme support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants