Skip to content

Conversation

@simonpane
Copy link
Collaborator

Minor documentation updates related to sourcing the Oracle Database Free RPMs from oracle.com, making use of the software library optional (for this edition only).

No functional changes to the toolkit - this PR includes documentation updates only.

@simonpane simonpane self-assigned this Aug 26, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simonpane
Once this PR has been reviewed and has the lgtm label, please assign alexbasinov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfielding would you like some words added to the ## Prerequisite Assumptions section (starts at line 7), either regarding the bucket being optional or directing readers to the free edition section at the bottom of this same doc?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, from a quickstart context, I think it would be great to have steps that can be copy and pasted in order. So adding verbiage to prerequisite assumptions sounds good, but we probably also want to make it clear that, when users run install-oracle.sh, they have two options: one for free edition, one for EE.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a little bit in a note in that section. Just let me know what changes to that you'd like.

@simonpane
Copy link
Collaborator Author

/retest

1 similar comment
@mfielding
Copy link
Member

/retest

@mfielding
Copy link
Member

/test all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants