Skip to content

Deprecate BatchRequest constructor #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 1, 2019
Merged

Deprecate BatchRequest constructor #1333

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
243255b
Deprecate the BatchRequest public constructor
chingor13 Jun 27, 2019
2bfea7b
Update Javadoc sample for batch request
chingor13 Jun 27, 2019
323c7bc
Log a warning if a user is using the global batch endpoint
chingor13 Jun 27, 2019
b794af5
Fix equality check for Strings
chingor13 Jun 27, 2019
74fef56
Swap equals comparison to avoid possible NPE
chingor13 Jul 1, 2019
f99668f
Add URL to visit in the warning message
chingor13 Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix equality check for Strings
  • Loading branch information
@chingor13
chingor13 committed Jun 27, 2019
commit b794af57a29fa010a78a487ba9a489ed1ceb232a
2 changes: 1 addition & 1 deletion google-api-client/src/main/java/com/google/api/client/googleapis/batch/BatchRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ public void execute() throws IOException {

// Log a warning if the user is using the global batch endpoint. In the future, we can turn this
// into a preconditions check.
if (this.batchUrl.toString() == GLOBAL_BATCH_ENDPOINT) {
if (this.batchUrl.toString().equals(GLOBAL_BATCH_ENDPOINT)) {
LOGGER.log(Level.WARNING, GLOBAL_BATCH_ENDPOINT_WARNING);
}

Expand Down