Skip to content

ci: fix the google style error in lint task in GitHub Actions #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

ci: fix the google style error in lint task in GitHub Actions #1695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5272568
ci: use Java 11 for lint
suztomo Feb 9, 2021
9770b11
refactor: to pass Google style lint
suztomo Feb 9, 2021
7089fcb
ci: install dependencies before running GitHub Actions
suztomo Feb 9, 2021
4495689
ci: excluding ci.yaml from automatic sync
suztomo Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
with:
java-version: ${{matrix.java}}
- run: java -version
- run: .kokoro/install_dependencies.sh
- run: .kokoro/build.sh
env:
JOB_TYPE: test
Expand Down Expand Up @@ -45,6 +46,7 @@ jobs:
with:
java-version: ${{matrix.java}}
- run: java -version
- run: .kokoro/install_dependencies.sh
- run: .kokoro/dependencies.sh
linkage-monitor:
runs-on: ubuntu-latest
Expand All @@ -54,15 +56,17 @@ jobs:
with:
java-version: 8
- run: java -version
- run: .kokoro/install_dependencies.sh
- run: .kokoro/linkage-monitor.sh
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v1
with:
java-version: 8
java-version: 11
- run: java -version
- run: .kokoro/install_dependencies.sh
- run: .kokoro/build.sh
env:
JOB_TYPE: lint
Expand All @@ -74,6 +78,7 @@ jobs:
with:
java-version: 8
- run: java -version
- run: .kokoro/install_dependencies.sh
- run: .kokoro/build.sh
env:
JOB_TYPE: clirr
6 changes: 2 additions & 4 deletions ...src/test/java/com/google/api/client/googleapis/auth/oauth2/GoogleIdTokenVerifierTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ private static Payload newPayload(String clientId) {
public void testBuilder() throws Exception {
GoogleIdTokenVerifier.Builder builder =
new GoogleIdTokenVerifier.Builder(
new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(),
new GsonFactory())
new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(), new GsonFactory())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn com.coveo:fmt-maven-plugin:format changed this line.

.setIssuer(ISSUER)
.setAudience(TRUSTED_CLIENT_IDS);
assertEquals(Clock.SYSTEM, builder.getClock());
Expand All @@ -70,8 +69,7 @@ public void testBuilder() throws Exception {
public void testVerify() throws Exception {
GoogleIdTokenVerifier verifier =
new GoogleIdTokenVerifier.Builder(
new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(),
new GsonFactory())
new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(), new GsonFactory())
Comment on lines -73 to +72
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn com.coveo:fmt-maven-plugin:format changed this line.

.build();
Header header = new Header();
header.setAlgorithm("RS25");
Expand Down
3 changes: 1 addition & 2 deletions ...c/test/java/com/google/api/client/googleapis/auth/oauth2/GooglePublicKeysManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ public LowLevelHttpResponse execute() {

public void testRefresh() throws Exception {
GooglePublicKeysManager certs =
new GooglePublicKeysManager.Builder(
new PublicCertsMockHttpTransport(), new GsonFactory())
new GooglePublicKeysManager.Builder(new PublicCertsMockHttpTransport(), new GsonFactory())
.build();
Comment on lines -104 to 105
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn com.coveo:fmt-maven-plugin:format changed this line.

certs.refresh();
assertEquals(2, certs.getPublicKeys().size());
Expand Down
1 change: 0 additions & 1 deletion google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import com.google.api.client.googleapis.testing.services.MockGoogleClient;
import com.google.api.client.googleapis.testing.services.MockGoogleClientRequest;
import com.google.api.client.http.ByteArrayContent;
import com.google.api.client.http.ExponentialBackOffPolicy;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn com.coveo:fmt-maven-plugin:format changed this line.

import com.google.api.client.http.GenericUrl;
import com.google.api.client.http.HttpContent;
import com.google.api.client.http.HttpExecuteInterceptor;
Expand Down
1 change: 1 addition & 0 deletions synth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@
"checkstyle.xml",
"renovate.json",
"license-checks.xml",
".github/workflows/ci.yaml",
])