Skip to content

feat: remove deprecated OOB flow #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2023
Merged

feat: remove deprecated OOB flow #2242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a60a2b
feat: remove deprecated OOB flow
meltsufin Jan 25, 2023
4aed098
chore: merge main
meltsufin Jan 26, 2023
519f3ed
chore: merge main
meltsufin Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions docs/component-modules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,6 @@ Jackson2 extensions to the Google API Client Library for Java
(`google-api-client-jackson2`). This module depends on `google-api-client` and
`google-http-client-jackson2`.

## google-api-client-java6

Java 6 (and higher) extensions to the Google API Client Library for Java
(`google-api-client-java6`). This module depends on `google-api-client` and
`google-oauth-client-java6`.

## google-api-client-protobuf

[Protocol buffer][protobuf] extensions to the Google API Client Library for Java
Expand Down
1 change: 0 additions & 1 deletion google-api-client-assembly/classpath-include
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<classpathentry kind="lib" path="libs/google-api-client-appengine-${project.version}.jar" sourcepath="libs-sources/google-api-client-appengine-${project.version}-sources.jar"/>
<classpathentry kind="lib" path="libs/google-api-client-gson-${project.version}.jar" sourcepath="libs-sources/google-api-client-gson-${project.version}-sources.jar"/>
<classpathentry kind="lib" path="libs/google-api-client-jackson2-${project.version}.jar" sourcepath="libs-sources/google-api-client-jackson2-${project.version}-sources.jar"/>
<classpathentry kind="lib" path="libs/google-api-client-java6-${project.version}.jar" sourcepath="libs-sources/google-api-client-java6-${project.version}-sources.jar"/>
<classpathentry kind="lib" path="libs/google-api-client-protobuf-${project.version}.jar" sourcepath="libs-sources/google-api-client-protobuf-${project.version}-sources.jar"/>
<classpathentry kind="lib" path="libs/google-api-client-servlet-${project.version}.jar" sourcepath="libs-sources/google-api-client-servlet-${project.version}-sources.jar"/>
<classpathentry kind="lib" path="libs/google-api-client-xml-${project.version}.jar" sourcepath="libs-sources/google-api-client-xml-${project.version}-sources.jar"/>
Expand Down
4 changes: 0 additions & 4 deletions google-api-client-assembly/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@
<groupId>com.google.api-client</groupId>
<artifactId>google-api-client-jackson2</artifactId>
</dependency>
<dependency>
<groupId>com.google.api-client</groupId>
<artifactId>google-api-client-java6</artifactId>
</dependency>
<dependency>
<groupId>com.google.api-client</groupId>
<artifactId>google-api-client-protobuf</artifactId>
Expand Down
5 changes: 0 additions & 5 deletions google-api-client-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,6 @@
<artifactId>google-api-client-jackson2</artifactId>
<version>2.1.4-SNAPSHOT</version><!-- {x-version-update:google-api-client:current} -->
</dependency>
<dependency>
<groupId>com.google.api-client</groupId>
<artifactId>google-api-client-java6</artifactId>
<version>2.1.4-SNAPSHOT</version><!-- {x-version-update:google-api-client:current} -->
</dependency>
<dependency>
<groupId>com.google.api-client</groupId>
<artifactId>google-api-client-protobuf</artifactId>
Expand Down
96 changes: 0 additions & 96 deletions google-api-client-java6/pom.xml
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions ...a/com/google/api/client/googleapis/extensions/java6/auth/oauth2/GooglePromptReceiver.java
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions ...main/java/com/google/api/client/googleapis/extensions/java6/auth/oauth2/package-info.java
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions ...ient/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleOAuthConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,5 @@ public class GoogleOAuthConstants {
public static final String DEFAULT_PUBLIC_CERTS_ENCODED_URL =
"https://www.googleapis.com/oauth2/v1/certs";

/**
* Redirect URI to use for an installed application as specified in <a
* href="https://developers.google.com/identity/protocols/OAuth2InstalledApp">Using OAuth 2.0 for
* Mobile & Desktop Apps</a>.
*/
public static final String OOB_REDIRECT_URI = "urn:ietf:wg:oauth:2.0:oob";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clirr is complaining about removal of this constant. It wasn't deprecated before. So, is it OK to remove?

Copy link
Contributor

@Neenu1995 Neenu1995 Jan 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the OOB flow will be blocked for all clients on January 31, I think it is safe to remove it. Keeping it won't prevent existing users from being broken.
That is my take, I will leave the final decision to you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Neenu.

Separately, can we hav one more release with "@deprecated" annotation with a link to a document that explains alternative(s).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we release this documentation enhancement #2244 first before stop publishing the artifact?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I merged your PR and will do a release before merging this and releasing again.


private GoogleOAuthConstants() {}
}
10 changes: 0 additions & 10 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
<module>google-api-client-bom</module>
<module>google-api-client-gson</module>
<module>google-api-client-jackson2</module>
<module>google-api-client-java6</module>
<module>google-api-client-protobuf</module>
<module>google-api-client-xml</module>
</modules>
Expand Down Expand Up @@ -178,11 +177,6 @@
<artifactId>google-api-client-android</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>com.google.api-client</groupId>
<artifactId>google-api-client-java6</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>com.google.api-client</groupId>
<artifactId>google-api-client-gson</artifactId>
Expand Down Expand Up @@ -410,10 +404,6 @@
<title>google-api-client-jackson2</title>
<packages>com.google.api.client.googleapis.notifications.json.jackson2.*</packages>
</group>
<group>
<title>google-api-client-java6</title>
<packages>com.google.api.client.googleapis.extensions.java6.*</packages>
</group>
<group>
<title>google-api-client-protobuf</title>
<packages>com.google.api.client.googleapis.services.protobuf*:com.google.api.client.googleapis.testing.services.protobuf*</packages>
Expand Down