Skip to content

fix!: IdTokenVerifier now throws IOException if any issue obtaining public keys. Adding retries to public key fetch to cover transient network issues. #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Aug 29, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
acb985f
verifier signature fix port
TimurSadykov Mar 23, 2022
1c16f8f
more test cases
TimurSadykov Mar 24, 2022
872f5f6
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 25, 2022
70ac584
fix: more test fixes
TimurSadykov Mar 28, 2022
5dde913
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 28, 2022
5c83d47
Update google-oauth-client/src/main/java/com/google/api/client/auth/o…
TimurSadykov Mar 30, 2022
17affb3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 30, 2022
4d34201
fix: restored original interface for verifier, added default http fac…
TimurSadykov Mar 31, 2022
9611f53
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 31, 2022
8b55b29
Update google-oauth-client/src/main/java/com/google/api/client/auth/o…
TimurSadykov Mar 31, 2022
813bb20
Update google-oauth-client/src/main/java/com/google/api/client/auth/o…
TimurSadykov Mar 31, 2022
e065d1a
doc fixes
TimurSadykov Mar 31, 2022
1af2370
fix: better docs and logging of validation exceptions
TimurSadykov Apr 3, 2022
22178ca
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Apr 3, 2022
c8d01d3
Update google-oauth-client/src/main/java/com/google/api/client/auth/o…
TimurSadykov Apr 12, 2022
aca11aa
nit and linter fixes
TimurSadykov Apr 12, 2022
1d668f8
Merge remote-tracking branch 'origin/main' into stim-signer
TimurSadykov May 31, 2022
6cd7d8c
fix: add verify without signature verification, remove caching empty …
TimurSadykov May 31, 2022
964c5a8
fix: docs for a new method
TimurSadykov May 31, 2022
d51d221
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 31, 2022
8f9f8f1
fix: docs for a new method
TimurSadykov Jun 1, 2022
ff2474e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jun 1, 2022
50eb0cc
fix: more test cases
TimurSadykov Jun 2, 2022
cc314d5
nit fixes for IdTokenVerifier
TimurSadykov Aug 12, 2022
7e7c69e
fix\!: IdtokenVerifier now throws IOException if any issue obtaining …
TimurSadykov Aug 19, 2022
3afaeaa
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 19, 2022
f7bcae2
merge with main
TimurSadykov Aug 19, 2022
0fe9873
fix: docs nit fixes
TimurSadykov Aug 25, 2022
c4e8d45
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 25, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: docs nit fixes
  • Loading branch information
TimurSadykov committed Aug 25, 2022
commit 0fe9873b9da3f36f70934a87e89a112dd91f0489
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ public final Collection<String> getAudience() {
*
* @param idToken ID token
* @return {@code true} if verified successfully or {@code false} if failed
* @throws IOException thrown if verification failed to run. For example, failure to get public
* @throws IOException if verification fails to run. For example, if it fails to get public
* keys for signature validation.
*/
public boolean verify(IdToken idToken) throws IOException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ public void testVerifyServiceAccountRs256Token() throws IOException {
.build();
assertTrue(tokenVerifier.verify(IdToken.parse(JSON_FACTORY, SERVICE_ACCOUNT_RS256_TOKEN)));

// a token with bad signature expected to fail in verify and work in verifyPayload
// a token with a bad signature that is expected to fail in verify, but work in verifyPayload
assertFalse(
tokenVerifier.verify(
IdToken.parse(JSON_FACTORY, SERVICE_ACCOUNT_RS256_TOKEN_BAD_SIGNATURE)));
Expand Down