-
Notifications
You must be signed in to change notification settings - Fork 128
fix: Close bq read client #3575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/gcbrun |
|
Hi @naung9 , Workaround: Have the PR target a non-main branch in the googleapis/java-bigquery repo. Merge into that branch. Open a PR from that "trusted" branch into main. If this is too much trouble, let me know if you want me to create the branch/PR for you with your changes and attribute the code to you in the PR description. |
|
Hi @PhongChuong , sorry to bother you. But I don't have permission to create a new branch in this Repo so please create a new branch for me to target my PR into. Or if you want me to target a specific existing branch, please tell me the branch name. I see 3 active branches in this repo |
|
@naung9 , let me update our instruction on how to contribute/push to main and get back to you soon (a day or 2). Our current instruction for contributors is lacking in this regard. Sorry for all the delays. |
|
@PhongChuong Sure. Take your time. I'll wait. |
|
@naung9 , I'm trying working on getting the process hammered out. Mean while, can you please check to see if you have permissions to push to this newly created branch: closeReadClient? |
|
@naung9 , this process seems to work:
|
|
@PhongChuong I tried pushing directly to the
Does it mean I have to create a new PR from my fork that points to |
The fork should point to 'main' directly. |
|
@PhongChuong I created a new PR here. So you can close this PR and continue on the new one. |
|
@naung9 , running tests on the new PR now. Thanks for all your patience with the process. Closing this PR. |
Shutdown
bqReadClientafter arrow stream is processed inhighThroughputReadto free up resourcesFixes #3571