feat: sql fast path impl #509

stephaniewang526 · 2020-07-04T00:42:25Z

Expose backend query() method in the client when QueryJobConfiguration is supported by QueryRequest

cc: @gcasto

google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryRequestInfo.java

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryRequestInfo.java

codecov · 2020-07-07T18:05:07Z

Codecov Report

Merging #509 into master will decrease coverage by 0.12%.
The diff coverage is 74.28%.

@@             Coverage Diff              @@
##             master     #509      +/-   ##
============================================
- Coverage     81.07%   80.94%   -0.13%     
- Complexity     1236     1261      +25     
============================================
  Files            78       79       +1     
  Lines          6334     6465     +131     
  Branches        705      735      +30     
============================================
+ Hits           5135     5233      +98     
- Misses          833      844      +11     
- Partials        366      388      +22

Impacted Files	Coverage Δ	Complexity Δ
.../java/com/google/cloud/bigquery/BigQueryError.java	`88.09% <ø> (ø)`	`14.00 <0.00> (ø)`
.../com/google/cloud/bigquery/spi/v2/BigQueryRpc.java	`82.60% <ø> (ø)`	`0.00 <0.00> (ø)`
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java	`4.90% <0.00%> (-0.05%)`	`2.00 <0.00> (ø)`
...a/com/google/cloud/bigquery/BigQueryException.java	`74.28% <64.28%> (-5.03%)`	`14.00 <5.00> (+3.00)`	⬇️
...va/com/google/cloud/bigquery/QueryRequestInfo.java	`73.13% <73.13%> (ø)`	`14.00 <14.00> (?)`
...n/java/com/google/cloud/bigquery/BigQueryImpl.java	`82.83% <80.00%> (-0.07%)`	`84.00 <6.00> (+7.00)`	⬇️
...m/google/cloud/bigquery/QueryJobConfiguration.java	`90.21% <100.00%> (+0.13%)`	`67.00 <1.00> (+1.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ca177...e161cf9. Read the comment docs.

add QueryJobConfig to QueryRequest logic high level mode reset private methods refactor: modified code update logic add test refactor: update code and test case add integration tests code format add clir ignore and remove pom file feat: add more assert nit update

enable requestId add integration tests for fast path multipages query, DML, and DDL queries fix requestId logic update QueryRequestInfo and add mock test add mock test cases for SQL, DML, and DDL clean up code fix IT add schema test

nit nit

google-cla · 2020-09-03T12:10:03Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java

epavan123

There are a number of warnings about uncovered lines. Please add tests to cover those.

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java

to address: google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryException.java#L69-L71 Added lines #L69 - L71 were not covered by tests

epavan123 · 2020-09-07T18:04:45Z

Hi,

Please hold on to the CL, I am looking into the interaction of this with some ongoing work to increase max row size limits.

stephaniewang526 · 2020-09-18T16:55:52Z

There are a number of warnings about uncovered lines. Please add tests to cover those.

Added more test coverage wherever possible.

🤖 I have created a release \*beep\* \*boop\* --- ## [1.120.0](https://www.github.com/googleapis/java-bigquery/compare/v1.119.0...v1.120.0) (2020-09-22) ### Features * sql fast path impl ([#509](https://www.github.com/googleapis/java-bigquery/issues/509)) ([64a7d65](https://www.github.com/googleapis/java-bigquery/commit/64a7d65ff97152c49194f507562266c1ba6f0f3b)), closes [google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryException.java#L69-L71](https://www.github.com/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryException.java/issues/L69-L71) [#L69](https://www.github.com/googleapis/java-bigquery/issues/L69) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

stephaniewang526 requested a review from shollyman July 4, 2020 00:42

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 4, 2020

stephaniewang526 requested a review from pmakani July 4, 2020 00:42

pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2020

epavan123 reviewed Jul 5, 2020

View reviewed changes

stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 6, 2020

stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2020

stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2020

stephaniewang526 force-pushed the sql-client branch from 30fe00c to e73936b Compare July 9, 2020 15:47

add logic for DML and DDL queries

d8ab960

enable requestId add integration tests for fast path multipages query, DML, and DDL queries fix requestId logic update QueryRequestInfo and add mock test add mock test cases for SQL, DML, and DDL clean up code fix IT add schema test

stephaniewang526 force-pushed the sql-client branch from aaa6b80 to d8ab960 Compare July 9, 2020 15:54

stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2020

stephaniewang526 force-pushed the sql-client branch from 9bc6b96 to 67e30a9 Compare July 10, 2020 23:10

update ITs to check table content correctness, update fastquery logic

780b836

nit nit

stephaniewang526 force-pushed the sql-client branch from 4148f5b to 780b836 Compare July 10, 2020 23:11

stephaniewang526 added 6 commits July 13, 2020 11:01

add test for bogus query

7126437

add check for idempotent requestId

08d6c7e

update QueryRequestInfo and error handling logic

31a55ce

add mock test for query JobException

bcecbb0

update mock test

81937fc

fix unit tests, nit update

b62b569

stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020

stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2020

Praful Makani added 2 commits September 3, 2020 17:29

Merge remote-tracking branch 'upstream/master' into sql-client

187c86e

update code

2862ad8

epavan123 reviewed Sep 3, 2020

View reviewed changes

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java Show resolved Hide resolved

epavan123 approved these changes Sep 3, 2020

View reviewed changes

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java Show resolved Hide resolved

stephaniewang526 added 3 commits September 3, 2020 15:43

add test coverage

d8f1229

to address: google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryException.java#L69-L71 Added lines #L69 - L71 were not covered by tests

Merge remote-tracking branch 'origin/sql-client' into sql-client

f7d73c4

lint fix

fd9dcae

stephaniewang526 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 7, 2020

Praful Makani and others added 5 commits September 11, 2020 16:31

feat: add more code cov

0cdf672

set method back

27d1a63

Merge branch 'master' into sql-client

23c9008

feat: code cove

48397ad

add codecov

e161cf9

stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2020

pmakani approved these changes Sep 22, 2020

View reviewed changes

stephaniewang526 merged commit 64a7d65 into googleapis:master Sep 22, 2020

relud mentioned this pull request Oct 1, 2020

Bump libraries-bom from 10.1.0 to 11.1.0 mozilla/gcp-ingestion#1422

Closed

meredithslota removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 13, 2020

googleapis deleted a comment from pmakani Nov 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: sql fast path impl #509

feat: sql fast path impl #509

Uh oh!

stephaniewang526 commented Jul 4, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 7, 2020 •

edited

Loading

Uh oh!

google-cla bot commented Sep 3, 2020

Uh oh!

Uh oh!

epavan123 left a comment

Uh oh!

Uh oh!

epavan123 commented Sep 7, 2020

Uh oh!

stephaniewang526 commented Sep 18, 2020

Uh oh!

Uh oh!

feat: sql fast path impl #509

feat: sql fast path impl #509

Uh oh!

Conversation

stephaniewang526 commented Jul 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

google-cla bot commented Sep 3, 2020

Uh oh!

Uh oh!

epavan123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

epavan123 commented Sep 7, 2020

Uh oh!

stephaniewang526 commented Sep 18, 2020

Uh oh!

Uh oh!

stephaniewang526 commented Jul 4, 2020 •

edited

Loading

codecov bot commented Jul 7, 2020 •

edited

Loading