Skip to content

Conversation

@rahulKQL
Copy link
Contributor

For documentation about the timestamp format for Mutation#setCell APIs.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2019
@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #39 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
+ Coverage      81.1%   81.26%   +0.15%     
- Complexity      914      937      +23     
============================================
  Files            93       95       +2     
  Lines          5701     5839     +138     
  Branches        302      325      +23     
============================================
+ Hits           4624     4745     +121     
+ Misses          919      918       -1     
- Partials        158      176      +18
Impacted Files Coverage Δ Complexity Δ
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 93.49% <0%> (-5.23%) 17% <0%> (ø)
...oud/bigtable/emulator/v2/BigtableEmulatorRule.java 90% <0%> (ø) 5% <0%> (?)
...om/google/cloud/bigtable/emulator/v2/Emulator.java 59.13% <0%> (ø) 14% <0%> (?)
...d/bigtable/data/v2/stub/readrows/StateMachine.java 87.59% <0%> (+31%) 15% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d3698...f1de192. Read the comment docs.

*
* <p>This is a convenience override that converts Strings to ByteStrings.
*
* <p>Note: The timestamp value could be -1 to use Bigtable server time. Otherwise, the user must
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not be advertising server timestamps. They don't play well with retries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I have reworded the JavaDoc. Please take a fresh look.

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulKQL rahulKQL merged commit f2d7c83 into googleapis:master Oct 29, 2019
@rahulKQL rahulKQL deleted the timestampDoc branch October 29, 2019 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants