chore: Temporarily move DirectPath tests back to the test endpoint. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al testing until the prod endpoint goes live
googlebot
added
the
cla: yes
igorbernstein2
changed the title
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage ? 81.29%
Complexity ? 937
=========================================
Files ? 95
Lines ? 5842
Branches ? 325
=========================================
Hits ? 4749
Misses ? 917
Partials ? 176Continue to review full report at Codecov.
|
kolea2
approved these changes
Oct 25, 2019
This was discovered while debugging another issue. While deflaking ReadRowRetryTest, this issue came up preventing me from seeing the underlying issue. ReframingResponseObserver#deliverUnsafe() should never fail. However if does, it will try to cancel the upstream stream and notify the downstream observer. However canceling the upstream can throw an exception and prevent the downstram observer from being notified of any error. This fix will catch cancellation errors and add them as suppressed exceptions to the original failure
kolea2
reviewed
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the prod DirectPath endpoint is not available yet. To unblock internal testing, update the test to target the test endpoint