fix: fix maven test configs to make sure admin tests don't clobber data tests #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kolea2
reviewed
Oct 28, 2019
google-cloud-bigtable/pom.xml
Outdated
| <test>com.google.cloud.bigtable.data.v2.it.**</test> | ||
| <test>com.google.cloud.bigtable.admin.v2.it.**</test> | ||
| <includes> | ||
| <include>com.google.cloud.bigtable.data.v2.it.**</include> |
Contributor
There was a problem hiding this comment.
is it possible to replace this with a one-liner: com.google.cloud.bigtable.**.v2.it.**? Not super familiar with the syntax here but wanted to check!
Contributor
Author
There was a problem hiding this comment.
Yep, updated. Thanks for the suggestion
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage 81.28% 81.28%
Complexity 937 937
=========================================
Files 95 95
Lines 5839 5839
Branches 325 325
=========================================
Hits 4746 4746
Misses 917 917
Partials 176 176Continue to review full report at Codecov.
|
kolea2
approved these changes
Oct 28, 2019
Contributor
kolea2
left a comment
kolea2
left a comment
There was a problem hiding this comment.
LGTM let's just confirm in logs it looks good before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.