Skip to content

Add section about gRPC version conflicts to README #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorbernstein2 merged 2 commits into from
Oct 30, 2019
Merged

Add section about gRPC version conflicts to README #53

igorbernstein2 merged 2 commits into from
Oct 30, 2019

Conversation

@justinuang
Copy link
Contributor

@justinuang justinuang commented Oct 29, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2019
@justinuang
Copy link
Contributor Author

justinuang commented Oct 29, 2019

@igorbernstein2

@justinuang justinuang mentioned this pull request Oct 29, 2019
Closed
igorbernstein2
igorbernstein2 approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM barring the warning nit

README.md Outdated

## Quickstart

WARNING: If you are experiencing version conflicts with gRPC, see [Version Conflicts](#version-conflicts).
Copy link
Contributor

@igorbernstein2 igorbernstein2 Oct 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this is a warning, it's more of a tip. Maybe just add the sentence after the examples?

Copy link
Contributor Author

@justinuang justinuang Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, not sure if that's what you wanted. If not, feel free to fix it and merge =)

@codecov
Copy link

codecov bot commented Oct 29, 2019 •
edited
Loading

Codecov Report

Merging #53 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #53      +/-   ##
============================================
- Coverage     81.29%   81.27%   -0.02%     
  Complexity      937      937              
============================================
  Files            95       95              
  Lines          5842     5842              
  Branches        325      325              
============================================
- Hits           4749     4748       -1     
- Misses          917      918       +1     
  Partials        176      176
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/bigtable/emulator/v2/Emulator.java 59.13% <0%> (-0.87%) 14% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbfa73a...ab3c17c. Read the comment docs.

@igorbernstein2 igorbernstein2 merged commit e5a7b0f into googleapis:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinuang @igorbernstein2 @googlebot