Skip to content

Conversation

@billyjacobson
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jan 26, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Jan 26, 2021
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #601 (2167c83) into master (8c16fa4) will increase coverage by 2.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #601      +/-   ##
============================================
+ Coverage     81.26%   83.44%   +2.17%     
- Complexity     1129     1198      +69     
============================================
  Files           106      110       +4     
  Lines          7047     7309     +262     
  Branches        370      383      +13     
============================================
+ Hits           5727     6099     +372     
+ Misses         1121     1009     -112     
- Partials        199      201       +2     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigtable/data/v2/BigtableDataSettings.java 69.44% <0.00%> (-2.39%) 8.00% <0.00%> (ø%)
...table/admin/v2/stub/BigtableInstanceAdminStub.java 3.70% <0.00%> (-0.15%) 1.00% <0.00%> (ø%)
...ogle/cloud/bigtable/data/v2/stub/BigtableStub.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../cloud/bigtable/data/v2/stub/GrpcBigtableStub.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...bigtable/admin/v2/stub/BigtableTableAdminStub.java 3.22% <0.00%> (ø) 1.00% <0.00%> (ø%)
...table/admin/v2/BaseBigtableTableAdminSettings.java 8.75% <0.00%> (ø) 2.00% <0.00%> (ø%)
...able/data/v2/stub/GrpcBigtableCallableFactory.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...le/admin/v2/BaseBigtableInstanceAdminSettings.java 9.21% <0.00%> (ø) 2.00% <0.00%> (ø%)
...v2/stub/GrpcBigtableTableAdminCallableFactory.java 50.00% <0.00%> (ø) 4.00% <0.00%> (ø%)
...stub/GrpcBigtableInstanceAdminCallableFactory.java 50.00% <0.00%> (ø) 4.00% <0.00%> (ø%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c16fa4...2167c83. Read the comment docs.

@kolea2 kolea2 changed the title Sample for configuring connection pool samples: Sample for configuring connection pool Jan 26, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 27, 2021
@billyjacobson billyjacobson marked this pull request as ready for review March 22, 2021 17:12
@billyjacobson billyjacobson requested a review from a team March 22, 2021 17:12
@billyjacobson billyjacobson merged commit 8b04cb9 into master Mar 23, 2021
@billyjacobson billyjacobson deleted the connection-pool branch March 23, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants