Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Conversation

@release-please
Copy link
Contributor

@release-please release-please bot commented Jul 8, 2022

🤖 I have created a release beep boop

1.0.0 (2022-07-11)

Features


This PR was generated with Release Please. See documentation.

@release-please release-please bot requested a review from a team as a code owner July 8, 2022 22:03
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: domains Issues related to the googleapis/java-domains API. labels Jul 8, 2022
suztomo
suztomo previously approved these changes Jul 8, 2022
@suztomo suztomo dismissed their stale review July 8, 2022 22:04

version needs to be verified

<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-cloud-domains-v1beta1</artifactId>
<version>0.7.1-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-domains-v1beta1:current} -->
<version>0.8.0</version><!-- {x-version-update:grpc-google-cloud-domains-v1beta1:current} -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this still 0.8.0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suztomo Do you expect this to get bumped to 1.0.0 as well? I double-checked another repo like speech and it does seem like the stable version has a major bump but the preview alpha/beta versions do not:

stable version: 2.5.3-SNAPSHOT https://github.com/googleapis/java-speech/blob/main/google-cloud-speech/pom.xml#L6

beta version: 0.89.3-SNAPSHOT https://github.com/googleapis/java-speech/blob/main/grpc-google-cloud-speech-v1beta1/pom.xml#L7

So if this is unexpected, then probably need to make the change in a template somewhere (as opposed to a one-off).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explanation. Then it's ok to have 0.8.0.

@release-please release-please bot force-pushed the release-please--branches--main branch from 70239c8 to 646db2f Compare July 11, 2022 21:45
@suztomo suztomo added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 13, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 13, 2022
@alicejli alicejli merged commit 64dcc3a into main Jul 13, 2022
@alicejli alicejli deleted the release-please--branches--main branch July 13, 2022 18:31
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 13, 2022
@release-please
Copy link
Contributor Author

@release-tool-publish-reporter

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: domains Issues related to the googleapis/java-domains API. autorelease: published size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants