-
Notifications
You must be signed in to change notification settings - Fork 3
chore(main): release 1.0.0 #249
Conversation
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>grpc-google-cloud-domains-v1beta1</artifactId> | ||
| <version>0.7.1-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-domains-v1beta1:current} --> | ||
| <version>0.8.0</version><!-- {x-version-update:grpc-google-cloud-domains-v1beta1:current} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this still 0.8.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suztomo Do you expect this to get bumped to 1.0.0 as well? I double-checked another repo like speech and it does seem like the stable version has a major bump but the preview alpha/beta versions do not:
stable version: 2.5.3-SNAPSHOT https://github.com/googleapis/java-speech/blob/main/google-cloud-speech/pom.xml#L6
beta version: 0.89.3-SNAPSHOT https://github.com/googleapis/java-speech/blob/main/grpc-google-cloud-speech-v1beta1/pom.xml#L7
So if this is unexpected, then probably need to make the change in a template somewhere (as opposed to a one-off).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for explanation. Then it's ok to have 0.8.0.
70239c8 to
646db2f
Compare
|
🤖 Release is at https://github.com/googleapis/java-domains/releases/tag/v1.0.0 🌻 |
|
The release build has started, the log can be viewed here. 🌻 |
|
🥚 You hatched a release! The release build finished successfully! 💜 |
🤖 I have created a release beep boop
1.0.0 (2022-07-11)
Features
This PR was generated with Release Please. See documentation.