Skip to content

Feat: client side metrics testing #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 118 commits into
base: main
Choose a base branch
from
Draft

Feat: client side metrics testing #1902

wants to merge 118 commits into from

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Oct 24, 2024 •
edited
Loading

  • Remove built-in metric EndToEndLatency and the MonitoredStreamResponseObserver class
  • Add resource attributes to be mapped to GCM monitored resource
  • Shutdown the metric reader when close/shutdown the firestore instance
  • Re-factor the telemetry constants
  • Add E2E integration tests against Google Cloud Monitoring and run against kightly only
  • Add E2E tests with InMemoryMetricReader
  • Add unit tests

milaGGL and others added 30 commits August 14, 2024 17:09
@milaGGL
enable 4 metrics from GAX
30a7011
@milaGGL
format
ed85413
@milaGGL
add default otel
57084c4
@milaGGL
format
571c095
@milaGGL
move constants out
f4b8416
@milaGGL
format
da0fe82
@milaGGL
add additional attributes
61432eb
@milaGGL
Merge branch 'main' into mila/client-side-metrics-demo
b5bfe5c
@milaGGL
add attributes to gax metrics
f0a029d
@milaGGL
Update BuiltinMetricsConstants.java
5456038
@milaGGL
remove current metrics implementation
5efaba6
@milaGGL
add custom exporter, add latency recorder
c0b4cc1
@milaGGL
use 2 otel instances
3979331
@milaGGL
set custom apiTracerFactory to gax
a9d08b5
@milaGGL
Merge branch 'main' into mila/client-side-metrics-demo2
029bd8c
@milaGGL
fix opentelemtry dependency version conflict issue
50e05fb
@milaGGL
use enabled/disabled style
53cd48a
@milaGGL
modify access modifiers
7adb9d6
@milaGGL
format
690e4ee
@milaGGL
rename boolean
e6f8ba6
@milaGGL
Merge branch 'main' into mila/client-side-metrics-demo2
c4ca4ae
@cloud-java-bot
chore: generate libraries at Fri Sep 27 19:25:02 UTC 2024
887221d
@milaGGL
Update pom.xml
a2c715a
@milaGGL
resolve comments from proto
ed78182
@milaGGL
e2E latency for runTransaction
e0d46be
@milaGGL
Merge branch 'main' into mila/client-side-metrics-demo2
a72a685
@cloud-java-bot
chore: generate libraries at Fri Oct 4 14:44:19 UTC 2024
92c83c1
@milaGGL
remove noise
c5137c1
@milaGGL
reformat code
63b5bd3
@milaGGL
re-format code
ac424a6
milaGGL and others added 27 commits November 15, 2024 11:14
@milaGGL
add tests that doesn't trigger rpc metrics
06c8c2d
@milaGGL
replace RunQuery.get with Query.get
a78cd66
@milaGGL
Update clirr-ignored-differences.xml
1228214
@milaGGL
Merge branch 'main' into mila/client-side-metrics-testing
edc8df0
@milaGGL
format
693260c
@milaGGL
refactor test code
16cd25f
@milaGGL
add E2E test
7f81d12
@milaGGL
Update ITE2EMetricsTest.java
25f9b59
@milaGGL
E2E tests verifys metrics are published only
ffe72db
@milaGGL
remove metricUtil shutdown
5d26ef7
@milaGGL
shutdown metricReader gracefully
c55f2f6
@milaGGL
format
457dde5
@milaGGL
configure unit tests to not enable metrics collection
95e088e
@milaGGL
skip E2E metric test unless running against nightly
ab9bb92
@milaGGL
remove override function for obsolete api in api tracer
02909a9
@milaGGL
Merge branch 'main' into mila/client-side-metrics-testing
a2c87c3
@cloud-java-bot
chore: generate libraries at Thu Nov 28 19:28:06 UTC 2024
f28794d
@cloud-java-bot
chore: generate libraries at Thu Nov 28 19:30:10 UTC 2024
3c2c017
@milaGGL
fix dependency error, test run E2E metric tests on CI
ec7556d
@milaGGL
Merge branch 'mila/client-side-metrics-testing' of https://github.com…
48f2079 
…/googleapis/java-firestore into mila/client-side-metrics-testing
@milaGGL
Merge branch 'main' into mila/client-side-metrics-testing
a735a18
@milaGGL
Merge branch 'main' into mila/client-side-metrics-testing
321379b
@cloud-java-bot
chore: generate libraries at Thu Apr 17 16:49:05 UTC 2025
d258d95
@milaGGL
fix the flakiness of the E2E tests
d97a85b
@milaGGL
remove end to end latency metric
c6baaa6
@milaGGL
format
d2e1e5c
@milaGGL
format TelemetryConstants, remove MonitoredStreamResponseObserver class
a899489
milaGGL
milaGGL commented May 1, 2025
View reviewed changes
google-cloud-firestore/src/main/java/com/google/cloud/firestore/StreamableQuery.java
throw error;
}
}

class MonitoredStreamResponseObserver implements ApiStreamObserver<RunQueryResponse> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since E2Elatency is removed, it does not make sense to have a class just to record first response latency: https://github.com/googleapis/java-firestore/pull/1840/files#r1809028150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milaGGL @cloud-java-bot