feat(regen): logging v2 #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chingor13
changed the title
chingor13
reviewed
Mar 27, 2020
| @@ -0,0 +1,2436 @@ | |||
| /* | |||
Collaborator
There was a problem hiding this comment.
@hzyi-google Is this naming correct?
Contributor
There was a problem hiding this comment.
Gapic config specified class renaming here. This regeneration deleted gapic config so the generator uses proto service name to generate client class name.
If the change cause problems with manual code or if you think this change is very user-unfriendly we can add the interface name override back (very easy fix). Otherwise if logging needs to take a major bump anyway, we may just squash this change into it as we don't need to be bothered by gapic v2.
vam-google
added a commit
to vam-google/java-logging
that referenced
this pull request
Mar 30, 2020
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: googleapis#111
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2020
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111
yoshi-automation
added a commit
that referenced
this pull request
Mar 30, 2020
c983911 commit c983911 Author: Vadym Matsishevskyi <[email protected]> Date: Mon Mar 30 13:47:15 2020 -0700 chore: Migrate logging synth.py to bazel (#124) This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111
yoshi-automation
added a commit
that referenced
this pull request
Apr 10, 2020
Source-Repo: googleapis/java-logging Source-Sha: c983911 Source-Link: c983911 Author: Vadym Matsishevskyi <[email protected]> Date: Mon Mar 30 13:47:15 2020 -0700 Original-Commit-Message: chore: Migrate logging synth.py to bazel (#124) This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111
yoshi-automation
added a commit
that referenced
this pull request
Apr 10, 2020
Source-Repo: googleapis/java-logging Source-Sha: c983911 Source-Link: c983911 Author: Vadym Matsishevskyi <[email protected]> Date: Mon Mar 30 13:47:15 2020 -0700 Original-Commit-Message: chore: Migrate logging synth.py to bazel (#124) This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111
yoshi-automation
added a commit
that referenced
this pull request
Apr 15, 2020
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111 Source-Author: Vadym Matsishevskyi <[email protected]> Source-Date: Mon Mar 30 13:47:15 2020 -0700 Source-Repo: googleapis/java-logging Source-Sha: c983911 Source-Link: c983911
yoshi-automation
added a commit
that referenced
this pull request
Apr 16, 2020
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111 Source-Author: Vadym Matsishevskyi <[email protected]> Source-Date: Mon Mar 30 13:47:15 2020 -0700 Source-Repo: googleapis/java-logging Source-Sha: c983911 Source-Link: c983911
yoshi-automation
added a commit
that referenced
this pull request
Apr 16, 2020
This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration. There is already an open PR with those braking changes: #111 Source-Author: Vadym Matsishevskyi <[email protected]> Source-Date: Mon Mar 30 13:47:15 2020 -0700 Source-Repo: googleapis/java-logging Source-Sha: c983911 Source-Link: c983911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/3ebc1c1a-5052-43a2-a644-2692e0b27cc2/targets