doc: add information about writing log entry modes #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
Contributor
Author
|
Unfortunately, the library does not provide a way to configure batching settings. It does not make sense to change the code in order to expose batching settings now. This change will be incorporated into the planed refactoring of the existing batching implementation. |
daniel-sanche
approved these changes
Sep 13, 2021
Contributor
daniel-sanche
left a comment
daniel-sanche
left a comment
There was a problem hiding this comment.
LGTM, but Simon should also probably take a look since he's more familiar with the java library than I am
simonz130
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide an explanation about synchronous and asynchronous modes for writing log entries and how the mode can be configured.
Fixes #665