chore: migrate to owlbot #669
Conversation
google-cla
bot
added
the
cla: yes
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: logging
minherz
left a comment
minherz
left a comment
There was a problem hiding this comment.
Would it be possible to comment on all the order changes in CI and POM files?
.github/workflows/ci.yaml
Outdated
| - uses: actions/checkout@v2 | ||
| - uses: stCarolas/setup-maven@v4 | ||
| with: | ||
| maven-version: 3.8.1 | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
what is a reason to change the order?
There was a problem hiding this comment.
The order of these commands across libraries is as owlbot's change here. Set up the environment first, then setup the maven version.
| <version>3.1.0</version> | ||
| <version>3.1.1</version> | ||
| </dependency> | ||
|
|
||
| ``` | ||
|
|
||
| If you are using Gradle 5.x or later, add this to your dependencies | ||
|
|
||
| ```Groovy | ||
| implementation platform('com.google.cloud:libraries-bom:22.0.0') | ||
| implementation platform('com.google.cloud:libraries-bom:23.0.0') |
There was a problem hiding this comment.
aren't these supposed to be auto-generated?
There was a problem hiding this comment.
They are autogenerated. When running the migration script, it picks up all the latest unmerged changes in the repo.
google-cloud-logging-bom/pom.xml
Outdated
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>proto-google-cloud-logging-v2</artifactId> | ||
| <version>0.90.2-SNAPSHOT</version><!-- {x-version-update:proto-google-cloud-logging-v2:current} --> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-logging</artifactId> | ||
| <version>3.1.2-SNAPSHOT</version><!-- {x-version-update:google-cloud-logging:current} --> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>grpc-google-cloud-logging-v2</artifactId> | ||
| <version>0.90.2-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-logging-v2:current} --> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-logging</artifactId> | ||
| <version>3.1.2-SNAPSHOT</version><!-- {x-version-update:google-cloud-logging:current} --> | ||
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>proto-google-cloud-logging-v2</artifactId> | ||
| <version>0.90.2-SNAPSHOT</version><!-- {x-version-update:proto-google-cloud-logging-v2:current} --> |
There was a problem hiding this comment.
is there any specific reason to change order of the dependencies?
There was a problem hiding this comment.
The change in the order of dependencies doesn't make any difference since maven creates its own dependency tree and resolves the order. Owlbot reorders the dependencies purely for consistency across libraries.
| <module>proto-google-cloud-logging-v2</module> | ||
| <module>grpc-google-cloud-logging-v2</module> | ||
| <module>google-cloud-logging</module> | ||
| <module>grpc-google-cloud-logging-v2</module> | ||
| <module>proto-google-cloud-logging-v2</module> |
There was a problem hiding this comment.
same question about the order.
There was a problem hiding this comment.
same. For consistency.
|
@minherz - this PR is autogenerated. I'm merging it. |
3 participants
No description provided.