Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

Conversation

@steinwaywhw
Copy link
Contributor

  • Change it to Integration Test per VPCSC team recommendation.
  • Use logging instead of System.out.println
  • Clean up resource after each test.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2019
@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #10 into master will increase coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
+ Coverage     71.91%   72.76%   +0.84%     
  Complexity      334      334              
============================================
  Files            30       30              
  Lines          2710     2710              
  Branches         15       38      +23     
============================================
+ Hits           1949     1972      +23     
  Misses          691      691              
+ Partials         70       47      -23
Impacted Files Coverage Δ Complexity Δ
...google/cloud/monitoring/v3/GroupServiceClient.java 61.53% <0%> (+0.96%) 26% <0%> (ø) ⬇️
.../cloud/monitoring/v3/UptimeCheckServiceClient.java 54.45% <0%> (+1.98%) 23% <0%> (ø) ⬇️
.../cloud/monitoring/v3/AlertPolicyServiceClient.java 63.21% <0%> (+3.44%) 23% <0%> (ø) ⬇️
...oogle/cloud/monitoring/v3/MetricServiceClient.java 64.2% <0%> (+4.54%) 35% <0%> (ø) ⬇️
...onitoring/v3/NotificationChannelServiceClient.java 64.49% <0%> (+5.32%) 43% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0ed15f...9999eb2. Read the comment docs.

@chingor13 chingor13 merged commit e80f2c7 into googleapis:master Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants