Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

test(samples): add retry setting in getUptimeCheckConfig for fix build #282

Merged
lesv merged 2 commits into from
Dec 14, 2020
Merged

test(samples): add retry setting in getUptimeCheckConfig for fix build #282

lesv merged 2 commits into from
Dec 14, 2020

Conversation

@suraj-qlogic
Copy link
Contributor

@suraj-qlogic suraj-qlogic commented Sep 30, 2020

Fixes #254

@suraj-qlogic suraj-qlogic requested a review from a team September 30, 2020 04:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020
@product-auto-label product-auto-label bot added api: monitoring Issues related to the googleapis/java-monitoring API. samples Issues that are directly related to samples. labels Sep 30, 2020
@suraj-qlogic suraj-qlogic self-assigned this Sep 30, 2020
@suraj-qlogic suraj-qlogic requested a review from chingor13 October 5, 2020 11:20
@codecov
Copy link

codecov bot commented Nov 5, 2020 •
edited
Loading

Codecov Report

Merging #282 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #282   +/-   ##
=========================================
  Coverage     78.01%   78.01%           
  Complexity      422      422           
=========================================
  Files            36       36           
  Lines          4067     4067           
  Branches         49       49           
=========================================
  Hits           3173     3173           
  Misses          831      831           
  Partials         63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2996f...08ac2ea. Read the comment docs.

@suraj-qlogic
Copy link
Contributor Author

suraj-qlogic commented Nov 5, 2020

@chingor13 ,gentle ping

@chingor13
Copy link
Contributor

chingor13 commented Nov 5, 2020

I don't think we want to do this. This setup code is in the sample and that test timed out once.

@lesv lesv merged commit 590723e into googleapis:master Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chingor13 chingor13 Awaiting requested review from chingor13

1 more reviewer

@lesv lesv lesv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@suraj-qlogic suraj-qlogic

Labels

api: monitoring Issues related to the googleapis/java-monitoring API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

com.example.UptimeIT: test2_GetUptimeCheck failed

3 participants

@suraj-qlogic @chingor13 @lesv