Skip to content

Conversation

@anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented May 19, 2020

This should fix ERROR: (gcloud.auth.activate-service-account) in tests.

Java 11 samples tests passed but Java 8 kept failing with this error:

[16:22:51][ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration java8-samples under /tmp/workspace/workspace/cloud-devrel/client-libraries/java/java-pubsub/presubmit/java8-samples/src/github/java-pubsub/.kokoro/presubmit.

I had a hard-to-spot typo in jave8-samples.cfg. It should have been java8-samples.cfg.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2020
@anguillanneuf anguillanneuf force-pushed the anguillanneuf-patch-1 branch from 5c314ca to 2c16757 Compare May 19, 2020 22:28
@anguillanneuf anguillanneuf changed the title chore: set env variables for tests chore: set env vars for tests and make it executable May 19, 2020
@anguillanneuf anguillanneuf added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 19, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 19, 2020
@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
Copy link
Contributor

@stephaniewang526 stephaniewang526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like Java 8 samples is still failing

@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #204 into master will decrease coverage by 0.51%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
- Coverage     78.88%   78.37%   -0.52%     
  Complexity      302      302              
============================================
  Files            21       21              
  Lines          2719     2719              
  Branches        150      150              
============================================
- Hits           2145     2131      -14     
  Misses          513      513              
- Partials         61       75      +14     
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/pubsub/v1/SubscriptionAdminClient.java 57.47% <0.00%> (-5.15%) 49.00% <0.00%> (ø%)
...a/com/google/cloud/pubsub/v1/TopicAdminClient.java 52.05% <0.00%> (-2.06%) 29.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ff18c...747c957. Read the comment docs.

@anguillanneuf anguillanneuf merged commit b488dbc into master May 20, 2020
@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch May 20, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants