Skip to content

Conversation

@michaelpri10
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@michaelpri10 michaelpri10 requested review from a team as code owners July 2, 2024 07:29
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/java-pubsub API. labels Jul 2, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jul 2, 2024
@michaelpri10 michaelpri10 merged commit 61257b8 into opentelemetry Jul 2, 2024
@michaelpri10 michaelpri10 deleted the opentelemetry-subscribe branch July 2, 2024 07:32
michaelpri10 added a commit that referenced this pull request Oct 1, 2024
* feat: Initial publish side Open Telemetry support

* feat: Publish-side trace context injection

* feat: Tests and improvements to publish side OTel tracing

* feat: More tests and refactoring for publish-side OpenTelemetry

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Formatting files

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Publisher test changes

* test: Fix OpenTelemetry test

* Feat: Use OpenTelemetry semconv

* test: Fix some dependency issues

* feat: Test fix

* feat: Add comment for setter in builder

* Opentelemetry subscribe (#2100)

* feat: Add OpenTelemetry tracing to the SubscriberClient

* feat: Add link to publisher create span in the subscribe process span

* feat: Add Ack/Nack/ModAck RPC spans to the subscribe

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Opentelemetry subscribe (#2101)

* feat: Add OpenTelemetry tracing to the SubscriberClient

* feat: Add link to publisher create span in the subscribe process span

* feat: Add Ack/Nack/ModAck RPC spans to the subscribe

* fix: Fix test errors caused by otel changes

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: Fix build errors in Publisher

* test: Ignore org.assertj:assertj-core which is required for OTel testing assertions

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: Add tests for subscriber OTel functions

* feat: Changes to OpenTelemetry implementation to add links earlier and prevent methods from being exposed to users

* feat: Refactor OpenTelemetry implementation to use a context aware wrapper for the tracer and a  PubsubTracer interface

* feat: Initialize default no-op PubsubTracer in Publisher and Subscriber

* feat: Ensure SubscriberStreamingConnection and MessageDispatcher have default no-op tracers by default for tests

* samples: Add OpenTelemetry publisher and subscriber samples

* feat: Add additional sampling checks to the Otel implementation

* samples: Update pom.xml for samples with Cloud Trace exporter

* feat: Make OTel classes/methods package-private and remove non-generic PubsubTracer interface

* feat: Lint fixes for Pub/Sub

* feat: Use MessagingIncubatingAttributes for gcp_pubsub attribute names

* feat: Format OTel changes

* Revert "feat: Use MessagingIncubatingAttributes for gcp_pubsub attribute names"

This reverts commit 305610e.

* feat: trigger build

* chore: generate libraries at Mon Sep 30 20:37:03 UTC 2024

* feat: trigger build

* feat: Fix file overwrite from bad merge

* chore: generate libraries at Mon Sep 30 20:49:40 UTC 2024

* Revert "chore: generate libraries at Mon Sep 30 20:49:40 UTC 2024"

This reverts commit 5ebbbf9.

* chore: generate libraries at Mon Sep 30 21:03:31 UTC 2024

* Revert "chore: generate libraries at Mon Sep 30 21:03:31 UTC 2024"

This reverts commit 23f3a70.

* chore: generate libraries at Mon Sep 30 21:14:11 UTC 2024

* feat: Prevent new files for OpenTelemetry from being overwritten

* feat: Revert automated file deletion for OpenTelemetry changes

* feat: Remove OpenTelemetry samples as the samples use a released library version to run

* chore: generate libraries at Mon Sep 30 22:11:14 UTC 2024

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant