Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

feat: make repo releasable, add parent/bom #1

Merged
merged 5 commits into from
Oct 31, 2019
Merged

feat: make repo releasable, add parent/bom #1

merged 5 commits into from
Oct 31, 2019

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Oct 25, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2019
@codecov
Copy link

codecov bot commented Oct 25, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@067023b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   76.81%           
  Complexity        ?      164           
=========================================
  Files             ?       12           
  Lines             ?     1458           
  Branches          ?       10           
=========================================
  Hits              ?     1120           
  Misses            ?      320           
  Partials          ?       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067023b...18ae56a. Read the comment docs.

@codyoss codyoss marked this pull request as ready for review October 28, 2019 13:31
@codyoss codyoss requested a review from chingor13 October 28, 2019 13:31
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2019
chingor13
chingor13 suggested changes Oct 30, 2019
View reviewed changes
.kokoro/presubmit/integration.cfg
key: "GCLOUD_PROJECT"
value: "gcloud-devel"
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and the continuous version) will need an additional environment variable:

env_vars: {
    key: "INTEGRATION_TEST_ARGS"
    value: "-Dredis.network=redis-vpc"
}

@codyoss codyoss requested a review from chingor13 October 30, 2019 14:15
chingor13
chingor13 approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to add the kokoro integration configs to the synth.py template ignores

@codyoss
Copy link
Member Author

codyoss commented Oct 30, 2019

Ooo good call, will do!

@codyoss codyoss merged commit 1b84248 into googleapis:master Oct 31, 2019
@codyoss codyoss deleted the release branch October 31, 2019 03:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codyoss @chingor13 @googlebot @kokoro-team