Skip to content

test: run it tests with LTS dependencies #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

thiagotnunes
Copy link
Contributor

No description provided.

@thiagotnunes thiagotnunes requested review from a team as code owners August 23, 2021 04:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Aug 23, 2021
@thiagotnunes thiagotnunes changed the base branch from master to 6.4.4-sp August 23, 2021 04:18
@thiagotnunes thiagotnunes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 23, 2021
@thiagotnunes thiagotnunes requested a review from suztomo August 23, 2021 04:19
@thiagotnunes
Copy link
Contributor Author

thiagotnunes commented Aug 23, 2021

@suztomo The integration tests work fine (I executed them from my local machine), but the dependency checks fail (upper bound requirements). I am not sure this is a problem

@suztomo
Copy link
Member

suztomo commented Aug 23, 2021

Upper bound check is ok to fail. The unit tests and integration tests are what I need to confirm. Great to hear they succeed.

@thiagotnunes thiagotnunes deleted the 6.4.4-sp-tests branch August 25, 2021 00:16
gcf-owl-bot bot added a commit that referenced this pull request Mar 7, 2022
* chore: update java template

* chore: fix tests

* chore: fix tests

* chore: update project
Source-Link: googleapis/synthtool@1155a97
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:b0b1c1c89570e229b1026372a2b8989ba31495007055b8d30178b7648503eefa
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 8, 2022
* chore: update java template

* chore: fix tests

* chore: fix tests

* chore: update project
Source-Link: googleapis/synthtool@1155a97
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:b0b1c1c89570e229b1026372a2b8989ba31495007055b8d30178b7648503eefa
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
* chore: update java template

* chore: fix tests

* chore: fix tests

* chore: update project
Source-Link: googleapis/synthtool@1155a97
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:b0b1c1c89570e229b1026372a2b8989ba31495007055b8d30178b7648503eefa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants