Skip to content

feat: increase default number of channels when gRPC-GCP channel pool is enabled #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 19, 2022
Merged

feat: increase default number of channels when gRPC-GCP channel pool is enabled #1997

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4b44b1a
increase default number of channels when grpc-gcp channel pool is ena…
harshachinta Sep 6, 2022
34d7623
Merge remote-tracking branch 'origin/main'
harshachinta Sep 6, 2022
860462a
add java file header
harshachinta Sep 6, 2022
f2e2d8f
increase default number of channels when grpc-gcp channel pool is ena…
harshachinta Sep 6, 2022
15e3155
fix lint issue
harshachinta Sep 6, 2022
7a3ed3c
fix lint issue
harshachinta Sep 6, 2022
1449429
code fixes
harshachinta Sep 7, 2022
5f516cb
Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Sp…
rajatbhatta Sep 7, 2022
afec666
Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Sp…
rajatbhatta Sep 7, 2022
1fe3d48
lint fixes
harshachinta Sep 8, 2022
60cfa2a
Merge remote-tracking branch 'origin/main'
harshachinta Sep 8, 2022
e68b2f5
Modify comments for better code readability
harshachinta Oct 6, 2022
a334e09
lint fix
harshachinta Oct 6, 2022
27962ea
add test to verify default num of channels when gRPC-GCP is not enabled
harshachinta Oct 11, 2022
68e72d4
Add tests to verify number of channels and the instances created
harshachinta Oct 18, 2022
33682fc
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 18, 2022
faa74ed
code refactoring for setting the default numChannels
harshachinta Oct 19, 2022
3d81b1f
Merge remote-tracking branch 'origin/main'
harshachinta Oct 19, 2022
a88d4e3
lint fix
harshachinta Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update google-cloud-spanner/src/main/java/com/google/cloud/spanner/Sp… 
…annerOptions.java
  • Loading branch information
@rajatbhatta
rajatbhatta authored Sep 7, 2022
commit 5f516cb7a8b7925416858b09cd798c59173d1432
2 changes: 1 addition & 1 deletion google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,7 @@ public SpannerOptions build() {
// As we are using plain text, we should never send any credentials.
this.setCredentials(NoCredentials.getInstance());
}
// Set the number of channels if not set
// Set the number of channels to DEFAULT_CHANNELS if not set
if (this.numChannels == null) {
// By default, we create 4 channels per {@link SpannerOptions}
this.numChannels = DEFAULT_CHANNELS;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.num

Suggested change
this.numChannels = DEFAULT_CHANNELS;
this.numChannels = this.grpcGcpExtensionEnabled ? GRPC_GCP_ENABLED_DEFAULT_CHANNELS : DEFAULT_CHANNELS;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion @olavloite. This makes it more readable than the previous one.
I have made the changes in the recent commit.

Expand Down