refactor: remove local variables, use static constants #2322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
|
@orischwartz: Thank you for raising the PR to Cloud Spanner Java Client. Can you please add the commit using conventionalcommits.org conventions? Something like: |
These are already defined in the base class AbstractStatementParser
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
rajatbhatta
changed the title
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
approved these changes
Mar 17, 2023
arpan14
pushed a commit
to arpan14/java-spanner
that referenced
this pull request
Apr 28, 2023
* refactor: remove local variables, use constants These are already defined in the base class AbstractStatementParser * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are defined in the base class AbstractStatementParser:
java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/AbstractStatementParser.java
Lines 475 to 486 in 30a32e9