Skip to content

samples: add support for updateDatabase in Cloud Spanner #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aayushimalik
Copy link
Contributor

No description provided.

@aayushimalik aayushimalik requested a review from a team as a code owner March 24, 2023 09:02
@snippet-bot
Copy link

snippet-bot bot commented Mar 24, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Mar 24, 2023
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aayushimalik: Could you please use the sample shared internally in the client spec doc to write this sample? It is to maintain consistency in the sample across clients.

@rajatbhatta rajatbhatta changed the title feat: drop database protection sample and sample test samples: add support for updateDatabase in Cloud Spanner Apr 4, 2023
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from a few minor nits.

@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner May 16, 2023 14:37
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@rajatbhatta rajatbhatta added the automerge Merge the pull request once unit tests and other checks pass. label May 16, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 6aadc2f into googleapis:main May 16, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants