Skip to content

samples: Bit Reversed Sequence support #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 2, 2023
Merged

samples: Bit Reversed Sequence support #2559

merged 9 commits into from
Aug 2, 2023

Conversation

rajatbhatta
Copy link
Contributor

No description provided.

@rajatbhatta rajatbhatta requested a review from a team as a code owner July 31, 2023 18:24
@snippet-bot
Copy link

snippet-bot bot commented Jul 31, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Jul 31, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner July 31, 2023 18:26
@rajatbhatta rajatbhatta marked this pull request as draft July 31, 2023 18:29
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 31, 2023
@rajatbhatta rajatbhatta marked this pull request as ready for review July 31, 2023 18:40
@rajatbhatta rajatbhatta requested a review from arpan14 July 31, 2023 18:53
arpan14
arpan14 reviewed Aug 2, 2023
View reviewed changes
samples/snippets/src/test/java/com/example/spanner/SequenceSampleIT.java

/** Integration tests for DML Returning samples for GoogleStandardSql dialect. */
@RunWith(JUnit4.class)
public class SequenceSampleIT extends SampleTestBase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not too much effort, can we have a single integration test and parameterise it for PG/Google SQL dialects. If no, can you add what are the differences in the way both dialects are tested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I've now parameterized the tests. Please take a look.

@rajatbhatta rajatbhatta added the automerge Merge the pull request once unit tests and other checks pass. label Aug 2, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7468a14 into main Aug 2, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the bit-rev-seq branch August 2, 2023 19:16
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpan14 arpan14 arpan14 approved these changes

Assignees

@averikitsch averikitsch

Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajatbhatta @arpan14 @averikitsch