Skip to content

chore: deduplicate code for batch updates #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

olavloite
Copy link
Collaborator

De-duplicate code that is equal for both the sync and async version of the executeBatchUpdate methods.

De-duplicate code that is equal for both the sync and async version of
the executeBatchUpdate methods.
@olavloite olavloite requested a review from rajatbhatta August 15, 2023 12:05
@olavloite olavloite requested a review from a team as a code owner August 15, 2023 12:05
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Aug 15, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner August 15, 2023 12:07
@olavloite olavloite requested review from manu2 and removed request for rajatbhatta September 1, 2023 18:28
Copy link

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite merged commit 1f850e9 into main Sep 6, 2023
@olavloite olavloite deleted the deduplicate-batch-update-methods branch September 6, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants