Skip to content

feat: Add support for Managed Autoscaler #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 19, 2023
Merged

feat: Add support for Managed Autoscaler #2624

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c36a99a
add the handwritten layer support for autoscaler
claire921 Sep 1, 2023
036601a
Address comments in the PR and add integration tests.
claire921 Oct 12, 2023
3930403
retrigger checks
claire921 Oct 13, 2023
bbfe85a
Address new comments
claire921 Oct 16, 2023
d9c1acc
fix the abstract method issue
claire921 Oct 17, 2023
e97f68c
Fix the instanceadminclientimpltest
claire921 Oct 18, 2023
40287ea
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the instanceadminclientimpltest
  • Loading branch information
@claire921
claire921 committed Oct 18, 2023
commit e97f68c163491f64576841f4bcdd1981457b826d
18 changes: 5 additions & 13 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/InstanceAdminClientImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,10 +330,10 @@ public void testCreateInstanceWithAutoscalingConfig() throws Exception {
.setAutoscalingConfig(getAutoscalingInstanceProto().getAutoscalingConfig())
.build());
assertTrue(operation.isDone());
assertEquals(INSTANCE_NAME, operation.get().getId().getName());
Instance instance = operation.get();
assertEquals(INSTANCE_NAME, instance.getId().getName());
assertEquals(
getAutoscalingInstanceProto().getAutoscalingConfig(),
operation.get().getAutoscalingConfig());
getAutoscalingInstanceProto().getAutoscalingConfig(), instance.getAutoscalingConfig());
}

@Test
Expand Down Expand Up @@ -398,23 +398,15 @@ public void testUpdateInstanceProcessingUnits() throws Exception {
"updateInstance",
getInstanceProtoWithProcessingUnits(),
UpdateInstanceMetadata.getDefaultInstance());
when(rpc.updateInstance(
instance,
FieldMask.newBuilder()
.addPaths("autoscaling_config")
.addPaths("processing_units")
.build()))
when(rpc.updateInstance(instance, FieldMask.newBuilder().addPaths("processing_units").build()))
.thenReturn(rawOperationFuture);
InstanceInfo instanceInfo =
InstanceInfo.newBuilder(InstanceId.of(INSTANCE_NAME))
.setInstanceConfigId(InstanceConfigId.of(CONFIG_NAME))
.setProcessingUnits(10)
.build();
OperationFuture<Instance, UpdateInstanceMetadata> operationWithFieldMask =
client.updateInstance(
instanceInfo,
InstanceInfo.InstanceField.AUTOSCALING_CONFIG,
InstanceInfo.InstanceField.PROCESSING_UNITS);
client.updateInstance(instanceInfo, InstanceInfo.InstanceField.PROCESSING_UNITS);
assertTrue(operationWithFieldMask.isDone());
assertEquals(INSTANCE_NAME, operationWithFieldMask.get().getId().getName());

Expand Down