Skip to content

feat: Open telemetry implementation #2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 8, 2024
Merged

feat: Open telemetry implementation #2770

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
30aa191
feat: OpenTelemetry Session Metrics and Traces
surbhigarg92 Sep 1, 2023
3907cbc
review comments
surbhigarg92 Oct 17, 2023
f0552ba
Removed setSpan method
surbhigarg92 Oct 18, 2023
aceb177
review comments
surbhigarg92 Oct 18, 2023
620f445
Metrics enable option
surbhigarg92 Nov 23, 2023
93b19f6
Bucket boundaries for latency metrics
surbhigarg92 Nov 28, 2023
bc86c8f
feat: refactor Spanner metrics and traces to use inject opentelemetry…
surbhigarg92 Dec 27, 2023
e1e59e2
feat: Refactor OpenTelemetry Tracer and Metrics
surbhigarg92 Dec 28, 2023
2543160
Readme
surbhigarg92 Jan 10, 2024
765edef
Review Comments
surbhigarg92 Jan 10, 2024
6e0239e
test
surbhigarg92 Jan 16, 2024
4a0acfb
Update README.md
surbhigarg92 Jan 22, 2024
b1c5590
review comments
surbhigarg92 Feb 7, 2024
a612357
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bucket boundaries for latency metrics
  • Loading branch information
@surbhigarg92
surbhigarg92 committed Feb 8, 2024
commit 93b19f68ae41fdc543c661903702c23ac5e6526f
15 changes: 8 additions & 7 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerRpcMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,18 @@
import io.opentelemetry.api.metrics.LongCounter;
import io.opentelemetry.api.metrics.LongHistogram;
import io.opentelemetry.api.metrics.Meter;
import java.util.Arrays;
import java.util.List;

@InternalApi
public class SpannerRpcMetrics {
private static LongHistogram gfeLatencies = null;
private static LongCounter gfeHeaderMissingCount = null;
private static final List<Long> RPC_MILLIS_BUCKET_BOUNDARIES =
Arrays.asList(
1L, 2L, 3L, 4L, 5L, 6L, 8L, 10L, 13L, 16L, 20L, 25L, 30L, 40L, 50L, 65L, 80L, 100L, 130L,
160L, 200L, 250L, 300L, 400L, 500L, 650L, 800L, 1000L, 2000L, 5000L, 10000L, 20000L,
50000L, 100000L);

static void initializeRPCMetrics(OpenTelemetry openTelemetry) {
if (openTelemetry == null || !SpannerMetrics.isRPCMetricsEnabled()) {
Expand All @@ -39,13 +46,7 @@ static void initializeRPCMetrics(OpenTelemetry openTelemetry) {
.ofLongs()
.setDescription(MetricRegistryConstants.SPANNER_GFE_LATENCY_DESCRIPTION)
.setUnit(MetricRegistryConstants.MILLISECOND)
// .setExplicitBucketBoundariesAdvice(
// Collections.unmodifiableList(
// Arrays.asList(
// 0.0, 0.01, 0.05, 0.1, 0.3, 0.6, 0.8, 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 8.0,
// 10.0, 13.0, 16.0, 20.0, 25.0, 30.0, 40.0, 50.0, 65.0, 80.0, 100.0, 130.0,
// 160.0, 200.0, 250.0, 300.0, 400.0, 500.0, 650.0, 800.0, 1000.0, 2000.0,
// 5000.0, 10000.0, 20000.0, 50000.0, 100000.0)))
.setExplicitBucketBoundariesAdvice(RPC_MILLIS_BUCKET_BOUNDARIES)
.build();
gfeHeaderMissingCount =
meter
Expand Down