test: fix ITDatabaseAdminTest failures #2976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
olavloite
requested changes
Mar 26, 2024
| ExecutionException e = | ||
| assertThrows(ExecutionException.class, () -> op.get(5, TimeUnit.MINUTES)); | ||
| assertThat(e.getMessage()).contains("Invalid field mask"); | ||
| SpannerException e = assertThrows(SpannerException.class, () -> op.get(5, TimeUnit.MINUTES)); |
There was a problem hiding this comment.
I'm pretty sure that the error that is returned by op.get() will be an ExecutionException, and not a SpannerException. However, the underlying cause of the ExecutionException should be a SpannerException.
(The build also fails because this assertion fails, as the returned exception is an ExecutionException).
There was a problem hiding this comment.
Thanks, I have fixed the asserts.
product-auto-label
bot
added
size: s
olavloite
approved these changes
Mar 26, 2024
arpan14
pushed a commit
to arpan14/java-spanner
that referenced
this pull request
Apr 1, 2024
* test: fix ITDatabaseAdminTest failures * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * exclude owlbot pre-processor run on kokoro config * remove reduntant assert * fix test --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes test failures
If you write sample code, please follow the samples format.