Skip to content

chore: propagate RuntimeException from DelayedReadContext #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

olavloite
Copy link
Collaborator

Propagate the underlying cause of the ExecutionException as a RuntimeException directly, if this is already a RuntimeException. This keeps the behavior of multiplexed sessions and regular sessions equal, regardless whether the Delayed... route is taken for multiplexed sessions, or the direct route is used.

Fixes #3132

Propagate the underlying cause of the ExecutionException as
a RuntimeException directly, if this is already a RuntimeException.
This keeps the behavior of multiplexed sessions and regular
sessions equal, regardless whether the Delayed... route is
taken for multiplexed sessions, or the direct route is used.

Fixes #3132
@olavloite olavloite requested a review from rahul2393 June 10, 2024 07:58
@olavloite olavloite requested a review from a team as a code owner June 10, 2024 07:58
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 10, 2024
@rahul2393 rahul2393 merged commit 71f56da into main Jun 18, 2024
33 of 34 checks passed
@rahul2393 rahul2393 deleted the issue-3132 branch June 18, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ITReadOnlyTxnTest is flaky with multiplexed sessions
2 participants